Re: [PATCH] iio: ak8975: constify ak_def structures

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: ak8975: constify ak_def structures
Date	2016-01-09 18:10 +0100
Message-ID	<qP5bz-8K-7@gated-at.bofh.it> (permalink)
References	<qNBpf-4ua-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/01/16 14:56, Julia Lawall wrote:
> The ak_def structures are never modified, so declare them as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
Applied, thanks.

Jonathan
> ---
>  drivers/iio/magnetometer/ak8975.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index b13936d..9c5c9ef 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -252,7 +252,7 @@ struct ak_def {
>  	u8 data_regs[3];
>  };
>  
> -static struct ak_def ak_def_array[AK_MAX_TYPE] = {
> +static const struct ak_def ak_def_array[AK_MAX_TYPE] = {
>  	{
>  		.type = AK8975,
>  		.raw_to_gauss = ak8975_raw_to_gauss,
> @@ -360,7 +360,7 @@ static struct ak_def ak_def_array[AK_MAX_TYPE] = {
>   */
>  struct ak8975_data {
>  	struct i2c_client	*client;
> -	struct ak_def		*def;
> +	const struct ak_def	*def;
>  	struct attribute_group	attrs;
>  	struct mutex		lock;
>  	u8			asa[3];
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: ak8975: constify ak_def structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-01-05 16:10 +0100
  Re: [PATCH] iio: ak8975: constify ak_def structures Jonathan Cameron <jic23@kernel.org> - 2016-01-09 18:10 +0100

csiph-web