Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

From	Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces
Date	2016-01-09 18:40 +0100
Message-ID	<qP5EC-k4-7@gated-at.bofh.it> (permalink)
References	(3 earlier) <qrQbD-5DG-5@gated-at.bofh.it> <qrTsS-7CR-27@gated-at.bofh.it> <qO7fs-H2-5@gated-at.bofh.it> <qODS2-6bk-3@gated-at.bofh.it> <qOJ1p-1u1-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 8, 2016, at 15:26, Eric Curtin wrote:
> As regards the "Unsupported brightness interface" log message will I
> add 101 to the switch statement so it doesn't get reported on my device
> or just remove it? This seems to be reporting many false positives (or
> negatives whatever way you want to look at it) on different machines so
> can I remove this logging?

Either remove the message, or leave it at debug level.  Do not add 101
to the switch case, please.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces Eric Curtin <ericcurtin17@gmail.com> - 2016-01-07 02:10 +0100
  Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces David Herrmann <dh.herrmann@gmail.com> - 2016-01-08 13:00 +0100
    Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces Eric Curtin <ericcurtin17@gmail.com> - 2016-01-08 18:30 +0100
      Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness  interfaces Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-09 18:40 +0100

csiph-web