Re: [PATCH 2/2] mmc: atmel: get rid of struct mci_dma_data

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mmc: atmel: get rid of struct mci_dma_data
Date	2016-01-09 13:20 +0100
Message-ID	<qP0EW-5qr-1@gated-at.bofh.it> (permalink)
References	<qOQvU-6F0-1@gated-at.bofh.it> <qOQvU-6F0-9@gated-at.bofh.it> <qP0EW-5qr-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> On Sat, Jan 9, 2016 at 3:22 AM, Mans Rullgard <mans@mansr.com> wrote:
>> As struct mci_dma_data is now only used by AVR32, it is nothing but
>> pointless indirection.  Replace it with struct dw_dma_slave in the
>> AVR32 platform code and with a void pointer elsewhere.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>
>> @@ -1376,15 +1375,15 @@ at32_add_device_mci(unsigned int id, struct mci_platform_data *data)
>>                                 ARRAY_SIZE(atmel_mci0_resource)))
>>                 goto fail;
>>
>> -       slave = kzalloc(sizeof(struct mci_dma_data), GFP_KERNEL);
>> +       slave = kzalloc(sizeof(*slave), GFP_KERNEL);
>>         if (!slave)
>>                 goto fail;
>>
>> -       slave->sdata.dma_dev = &dw_dmac0_device.dev;
>> -       slave->sdata.src_id = 0;
>> -       slave->sdata.dst_id = 1;
>> -       slave->sdata.m_master = 1;
>> -       slave->sdata.p_master = 0;
>
> Seems you based this on top of our non-submitted yet patches.

You're right.  I didn't realise this file had been touched by those
patches, and I didn't read the code all that carefully when making this
change.

>> +       slave->dma_dev = &dw_dmac0_device.dev;
>> +       slave->src_id = 0;
>> +       slave->dst_id = 1;
>> +       slave->m_master = 1;
>> +       slave->p_master = 0;
>
> -- 
> With Best Regards,
> Andy Shevchenko

-- 
Måns Rullgård

Thread

[PATCH 1/2] mmc: atmel-mci: restore dma on AVR32 Mans Rullgard <mans@mansr.com> - 2016-01-09 02:30 +0100
  [PATCH 2/2] mmc: atmel: get rid of struct mci_dma_data Mans Rullgard <mans@mansr.com> - 2016-01-09 02:30 +0100
    Re: [PATCH 2/2] mmc: atmel: get rid of struct mci_dma_data Måns Rullgård <mans@mansr.com> - 2016-01-09 13:20 +0100
    Re: [PATCH 2/2] mmc: atmel: get rid of struct mci_dma_data Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-09 13:20 +0100

csiph-web