Re: [PATCH] usb: gadget: fix error handling

X-FeedAbuse	http://nntpfeed.proxad.net/abuse.pl feeded by 195.154.70.45
Path	csiph.com!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!proxad.net!feeder1-2.proxad.net!nntpfeed.proxad.net!news.redatomik.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Peter Chen <hzpeterchen@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: gadget: fix error handling
Date	Fri, 08 Jan 2016 07:10:02 +0100
Message-ID	<qOypk-2DF-11@gated-at.bofh.it> (permalink)
References	<qOiuf-6b-27@gated-at.bofh.it>
X-Original-To	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=JxylQFRNhTXM/vGLogwpIWt9+kddECIYj5MzQD5CZDE=; b=UF9+e9wyz86pEFNmhmWn+w810Sm7dQaN/CarJ0fPcEctfd4PrDxRr6cCpqvLGrgzVa ntowz/LBzRxcuFH2ghV2/NHIs6Y5i3P67eqd93rkh3xF6rU4exrM/LBqY35j1l56uDew HpmHJf3ZaeHXV8e8htTdg7Gg1KX5ip0IuwZrHyC6EkdLdNypcwXjA+yJF7YyXxpaXoVL USA1+7djdLJZyoEwuTLcoQNp+VZH7V7U002dHqmCLHnMyS+EKGu30Vgp7T8TrKvhuBX6 e/TYs45yE0+snC61wyoLtfNtBRLqmozwd8LNjeqlFW3cqRVofhNIc2i7jrqR7VAJqOyb KxNQ==
X-Received	by 10.66.150.200 with SMTP id uk8mr13004851pab.116.1452233012119; Thu, 07 Jan 2016 22:03:32 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
X-Original-Date	Fri, 8 Jan 2016 14:01:12 +0800
X-Original-Message-ID	<20160108060112.GB26697@shlinux2>
X-Original-References	<1452171637-25143-1-git-send-email-sudipm.mukherjee@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1304201

Show key headers only | View raw

On Thu, Jan 07, 2016 at 06:30:37PM +0530, Sudip Mukherjee wrote:
> We are doing PTR_ERR() of NULL, and that will actually make ret = 0.
> So incase of both error and success we are actually returning the
> success code.
> 

%s/incase of/in case of

Reviewed-by: Peter Cen <peter.chen@freescale.com>

> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/usb/gadget/composite.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 8b14c2a..17ce6b5 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -2017,14 +2017,14 @@ int composite_os_desc_req_prepare(struct usb_composite_dev *cdev,
>  
>  	cdev->os_desc_req = usb_ep_alloc_request(ep0, GFP_KERNEL);
>  	if (!cdev->os_desc_req) {
> -		ret = PTR_ERR(cdev->os_desc_req);
> +		ret = -ENOMEM;
>  		goto end;
>  	}
>  
>  	/* OS feature descriptor length <= 4kB */
>  	cdev->os_desc_req->buf = kmalloc(4096, GFP_KERNEL);
>  	if (!cdev->os_desc_req->buf) {
> -		ret = PTR_ERR(cdev->os_desc_req->buf);
> +		ret = -ENOMEM;
>  		kfree(cdev->os_desc_req);
>  		goto end;
>  	}
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 

Best Regards,
Peter Chen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: fix error handling Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-07 14:10 +0100
  Re: [PATCH] usb: gadget: fix error handling Peter Chen <hzpeterchen@gmail.com> - 2016-01-08 07:10 +0100

csiph-web