RE: [PATCH V2 0/3] Change notes of V2

From	"Yu, Xiangliang" <Xiangliang.Yu@amd.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH V2 0/3] Change notes of V2
Date	2016-01-08 04:10 +0100
Message-ID	<qOvB7-xR-7@gated-at.bofh.it> (permalink)
References	<qINr4-7o4-11@gated-at.bofh.it> <qO10m-4M5-13@gated-at.bofh.it> <qO9AC-2gg-1@gated-at.bofh.it> <qOk30-YY-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


Hi ,




> > > In particular, I think we need feedback on #3 from PCI and power
> > > management maintainers.
> >
> > I don't get your concern.
> > I think we can add device attribute file to let application to trigger
> > wakeup function, then NTB hardware will do the rest. NTB driver just
> > need to implement suspend/resume interface of PCI PM.
> >
> > Add one more thing, do you think NTB should support runtime power
> > management?
> >
> 
> I think it is good to make the power management functionality available.  In
> other words, yes, to your last question.

Got it.

> My concern is that I would like some degree of certainty that it is done right,
> in harmony with the rest of the kernel.  I don't know what "done right"
> means in this case, which is why I would like someone else to review it.  A
> smaller patch with only (and all of) the power management code will have a
> better chance of being reviewed.

I think it is ok if following the PM interface and test pass. This version I'll remove 
the PM part and will submit all related PM patch when runtime code is ready.

> I'm also concerned about the waiting behavior in #2 and #3.  I'm not saying
> it's wrong.  At least now that behavior is noted in the api documentation;
> thanks for that.  If a PCI or power management expert has no objection to
> the waiting behavior in #3, then I would be comfortable with that behavior in
> #2 as well.

I also don't like the waiting behavior, but I can't find the asynchronous method to
Let application know the result. And I think #2 is different from #3 because it isn't
related to PM or PCI. Please let me know if you have better choice.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH V2 0/3] Change notes of V2 "Allen Hubbe" <Allen.Hubbe@emc.com> - 2016-01-06 19:30 +0100
  RE: [PATCH V2 0/3] Change notes of V2 "Yu, Xiangliang" <Xiangliang.Yu@amd.com> - 2016-01-07 04:40 +0100
    RE: [PATCH V2 0/3] Change notes of V2 "Allen Hubbe" <Allen.Hubbe@emc.com> - 2016-01-07 15:50 +0100
      RE: [PATCH V2 0/3] Change notes of V2 "Yu, Xiangliang" <Xiangliang.Yu@amd.com> - 2016-01-08 04:10 +0100

csiph-web