Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304076

[PATCH v3 4/5] xfs: unmap dax at shutdown (force_failure)

Show all headers | View raw

When an exceptional event triggers xfs_force_shutdown() tear down dax
mappings.  Quoting Dave,

    "The simple fact is that a /filesystem/ shutdown needs to do DAX
    mapping invalidation regardless of whether the block device has
    been unplugged or not. This is not a case of "this only happens
    when we unplug the device", this is a user data protection
    mechanism that we use to prevent corruption propagation once it
    has been detected. A device unplug is just one type of
    "corruption" that can occur."

Acked-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 fs/xfs/xfs_fsops.c |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
index ee3aaa0a5317..0c6a52809dcc 100644
--- a/fs/xfs/xfs_fsops.c
+++ b/fs/xfs/xfs_fsops.c
@@ -828,6 +828,15 @@ xfs_do_force_shutdown(
 	if (xfs_log_force_umount(mp, logerror))
 		return;
 
+	/*
+	 * If DAX is in use, we have to unmap all direct access virtual
+	 * mappings to ensure nothing more gets written directly from
+	 * userspace. This will force them to refault and that will
+	 * result in them detecting the shutdown condition and hence
+	 * will fail appropriately.
+	 */
+	unmap_dax_inodes(mp->m_super);
+
 	if (flags & SHUTDOWN_CORRUPT_INCORE) {
 		xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_CORRUPT,
     "Corruption of in-memory data detected.  Shutting down filesystem");

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] fs, block: handle end of life Dan Williams <dan.j.williams@intel.com> - 2016-01-08 01:50 +0100
  [PATCH v3 4/5] xfs: unmap dax at shutdown (force_failure) Dan Williams <dan.j.williams@intel.com> - 2016-01-08 01:50 +0100
  [PATCH v3 2/5] block: introduce del_gendisk_queue() Dan Williams <dan.j.williams@intel.com> - 2016-01-08 01:50 +0100
  [PATCH v3 3/5] block: introduce force_failure_partition() and  unmap_dax_inodes() Dan Williams <dan.j.williams@intel.com> - 2016-01-08 01:50 +0100
  [PATCH v3 5/5] block, xfs: implement 'force_failure' notifications Dan Williams <dan.j.williams@intel.com> - 2016-01-08 01:50 +0100

csiph-web