Re: [PATCH v4] memory-hotplug: Fix kernel warning during memory hotplug on ppc64

From	Dave Hansen <dave.hansen@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] memory-hotplug: Fix kernel warning during memory hotplug on ppc64
Date	2016-01-08 02:20 +0100
Message-ID	<qOtSG-7Ne-1@gated-at.bofh.it> (permalink)
References	<qO4Uj-7jF-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/06/2016 02:30 PM, John Allen wrote:
> On any architecture that uses memory_probe_store to reserve memory, the
> udev rule will be triggered after the first section of the block is
> reserved and will subsequently attempt to online the entire block,
> interrupting the memory reservation process and causing the warning.
> This patch modifies memory_probe_store to add a block of memory with
> a single call to add_memory as opposed to looping through and adding
> each section individually. A single call to add_memory is protected by
> the mem_hotplug mutex which will prevent the udev rule from onlining
> memory until the reservation of the entire block is complete.

Seems sane to me.  Makes the code simpler too, so win win.

Acked-by: Dave Hansen <dave.hansen@intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] memory-hotplug: Fix kernel warning during memory hotplug  on ppc64 John Allen <jallen@linux.vnet.ibm.com> - 2016-01-06 23:40 +0100
  Re: [PATCH v4] memory-hotplug: Fix kernel warning during memory  hotplug on ppc64 Andrew Morton <akpm@linux-foundation.org> - 2016-01-07 23:50 +0100
  Re: [PATCH v4] memory-hotplug: Fix kernel warning during memory  hotplug on ppc64 Dave Hansen <dave.hansen@intel.com> - 2016-01-08 02:20 +0100

csiph-web