Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1304019

Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain

From "Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups linux.kernel
Subject Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain
Date 2016-01-08 00:50 +0100
Message-ID <qOstA-6LL-17@gated-at.bofh.it> (permalink)
References <qodzP-6jT-7@gated-at.bofh.it> <qtdzd-3g9-45@gated-at.bofh.it> <qOk30-YY-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thursday, January 07, 2016 03:47:01 PM Tomeu Vizoso wrote:
> On 10 November 2015 at 10:33, Daniel Kurtz <djkurtz@chromium.org> wrote:
> [snip]
> >
> > The problem appears to be that:
> >   * On boot, platform_drv_probe() calls dev_pm_domain_attach() before
> > drv->probe(); thus, it calls dev_pm_domain_attach() while the device
> > is unbound.
> >
> >  * However, for a platform_device, the reboot path calls
> > device_shutdown(), but not __device_release_driver():
> > device_shutdown()
> >   dev->driver->shutdown => platform_drv_shutdown()
> >     dev_pm_domain_detach()
> >        dev->pm_domain->detach() => genpd_dev_pm_detach()
> >          pm_genpd_remove_device()
> >             dev_pm_domain_set(dev, NULL);
> >
> > So, for a platform_device in a genpd power domain with .shutdown
> > installed, platform_drv_shutdown() calls dev_pm_domain_detach() while
> > the device is still bound, which triggers the WARN().
> 
> Hi Rafael, Alan and Ulf,
> 
> do you have any suggestion about this? I don't really understand why
> the device is detached from the domain on shutdown.

Well, this looks like a bug to me.

Thanks,
Rafael

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-01-07 15:50 +0100
  Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-08 00:50 +0100
  Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain Fabio Estevam <festevam@gmail.com> - 2016-01-11 15:40 +0100
    Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-11 15:50 +0100
      Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain Fabio Estevam <festevam@gmail.com> - 2016-01-11 16:00 +0100
      Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain Ulf Hansson <ulf.hansson@linaro.org> - 2016-01-11 22:20 +0100

csiph-web