Re: [PATCH] ACPI, PCI, irq: remove redundant check for null string pointer

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ACPI, PCI, irq: remove redundant check for null string pointer
Date	2016-01-08 01:20 +0100
Message-ID	<qOsWD-7b8-19@gated-at.bofh.it> (permalink)
References	<qNxvm-Wb-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, January 05, 2016 10:57:11 AM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> source is decleared as a 4 byte char array in struct acpi_pci_routing_table
> so !prt->source is a redundant null string pointer check. Detected with
> smatch:
> 
> drivers/acpi/pci_irq.c:134 do_prt_fixups() warn: this array is probably
>   non-NULL. 'prt->source'
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks!

> ---
>  drivers/acpi/pci_irq.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index c933675..d30184c 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -131,9 +131,6 @@ static void do_prt_fixups(struct acpi_prt_entry *entry,
>  		quirk = &prt_quirks[i];
>  
>  		/* All current quirks involve link devices, not GSIs */
> -		if (!prt->source)
> -			continue;
> -
>  		if (dmi_check_system(quirk->system) &&
>  		    entry->id.segment == quirk->segment &&
>  		    entry->id.bus == quirk->bus &&
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ACPI, PCI, irq: remove redundant check for null string pointer Colin King <colin.king@canonical.com> - 2016-01-05 12:00 +0100
  Re: [PATCH] ACPI, PCI, irq: remove redundant check for null string pointer "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-08 01:20 +0100

csiph-web