Re: [PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong
Date	2016-01-07 20:20 +0100
Message-ID	<qOogi-431-3@gated-at.bofh.it> (permalink)
References	<qO5Qm-7Zi-23@gated-at.bofh.it> <qOh57-7sH-11@gated-at.bofh.it> <qOnNg-3C6-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Kees,

On Thu, Jan 7, 2016 at 7:40 PM, Kees Cook <keescook@chromium.org> wrote:
>> Also, I suspect that all of the decompressor should be built with
>> -fno-stack-protector as we don't have sufficient environment here.
>> Maybe it should be placed in the global CFLAGS for the decompressor?
>
> I prefer keeping it disabled in as narrow a range as possible. If
> other code gains a level of complexity that it triggers the stack
> protector code insertion, I think that's worth examining when it
> happens. If this ever becomes an actual burden, then yeah, let's do it
> for the whole decompressor, but I think it'd be best to revisit it if
> it happens again.

What's the failure mode if the stack protector code insertion is triggered?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong Kees Cook <keescook@chromium.org> - 2016-01-07 00:40 +0100
  Re: [PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong Arnd Bergmann <arnd@arndb.de> - 2016-01-07 11:50 +0100
  Re: [PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-07 12:40 +0100
    Re: [PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong Kees Cook <keescook@chromium.org> - 2016-01-07 19:50 +0100
      Re: [PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-07 20:20 +0100
        Re: [PATCH v3] ARM: fix atags_to_fdt with stack-protector-strong Kees Cook <keescook@chromium.org> - 2016-01-07 20:20 +0100

csiph-web