Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303784

Re: linux-next: build failure after merge of the rcu tree

Show all headers | View raw

On Thu, Jan 07, 2016 at 07:57:25PM +1100, Stephen Rothwell wrote:
> Hi Paul,
> 
> [I found this a few days ago, but I think I forgot to send the email,
> sorry.]
> 
> After merging the rcu tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> kernel/rcu/rcuperf.o:(.discard+0x0): multiple definition of `__pcpu_unique_srcu_ctl_srcu_array'
> kernel/rcu/rcutorture.o:(.discard+0x0): first defined here
> 
> Caused by commit
> 
>   abcd7ec0808e ("rcutorture: Add RCU grace-period performance tests")
> 
> I have reverted that commit for today.

Hello, Stephen,

Very strange.  The "static" keyword does not mean anything here?
Easy enough to use different symbols in the two different files,
but this situation is not so good for information hiding.

Happy to update rcuperf.c to use a different name, but in the
immortal words of MSDOS, "Are you sure?" :-)

						Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the rcu tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-01-07 10:00 +0100
  Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-01-07 19:30 +0100
    Re: linux-next: build failure after merge of the rcu tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-01-07 21:20 +0100
      Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-01-07 22:00 +0100
        Re: linux-next: build failure after merge of the rcu tree Boqun Feng <boqun.feng@gmail.com> - 2016-01-08 02:40 +0100
          Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-01-08 04:50 +0100
            Re: linux-next: build failure after merge of the rcu tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-01-08 05:10 +0100
              Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-01-08 05:50 +0100
                Re: linux-next: build failure after merge of the rcu tree Boqun Feng <boqun.feng@gmail.com> - 2016-01-08 06:00 +0100
                Re: linux-next: build failure after merge of the rcu tree Tejun Heo <tj@kernel.org> - 2016-01-08 17:00 +0100
                Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-01-08 17:20 +0100
                Re: linux-next: build failure after merge of the rcu tree Boqun Feng <boqun.feng@gmail.com> - 2016-01-08 17:00 +0100
                Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-01-08 17:00 +0100
          Re: linux-next: build failure after merge of the rcu tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-01-08 05:20 +0100

csiph-web