Re: [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix error path

From	Peter Senna Tschudin <peter.senna@collabora.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix error path
Date	2016-01-07 16:20 +0100
Message-ID	<qOkw2-1qX-7@gated-at.bofh.it> (permalink)
References	<qND7I-5u9-5@gated-at.bofh.it> <qND7I-5u9-3@gated-at.bofh.it> <qO10m-4M5-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 06, 2016 at 09:28:41PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 1/5/2016 7:54 PM, Peter Senna Tschudin wrote:
> 
> >From: Peter Senna Tschudin <peter.senna@gmail.com>
> >
> >This patch remove four calls to dev_err() from sisusb_probe() as
> >reporting memory allocation failures is redundant:
> >
> >  - Remove a call to dev_err() that was reporting unsuccesful call to
> >    kzalloc().
> >
> >  - Remove two calls to dev_err() that were reporting unsuccesful calls
> >    to kmalloc().
> >
> >  - Remove a call to dev_err() that was reporting unsuccesful call to
> >    kmalloc(), and replace it by code that clean up previously allocated
> >    resources and abort the probe with -ENOMEM. Before this modification
> >    sisusb->SiS_Pr could be dereferenced even it was null.
> 
>    I think the bug fix should be in its own patch. Don't intermix fixes with
> cleanups please.

Ok, I'll resend the series with the following changes:
 - split patch 1: vertical and horizontal changes
 - split patch 4: cleanups and fix

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix error path Peter Senna Tschudin <peter.senna@collabora.com> - 2016-01-05 18:00 +0100
  Re: [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix  error path Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-01-06 19:30 +0100
    Re: [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix  error path Peter Senna Tschudin <peter.senna@collabora.com> - 2016-01-07 16:20 +0100

csiph-web