Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303633

Re: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs()

Show all headers | View raw

On 01/07/2016 01:07 AM, Linus Walleij wrote:
> On Thu, Jan 7, 2016 at 1:20 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> Commit 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") replaces
>> the use of container_of() with gpiochip_get_data(). Unfortunately, the
>> data pointer is not yet set by the time xgpio_save_regs() is called,
>> causing a system hang.
>>
>> Fixes: 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> It might make sense to merge this patch with the patch introducing the problem.
>
> Patch applied, thanks for finding and fixing this so quick!
>
Code inspection shows that there are two more - I'll send patches today.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs() Guenter Roeck <linux@roeck-us.net> - 2016-01-07 01:30 +0100
  Re: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs() Linus Walleij <linus.walleij@linaro.org> - 2016-01-07 10:10 +0100
    Re: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in  xgpio_save_regs() Guenter Roeck <linux@roeck-us.net> - 2016-01-07 16:00 +0100

csiph-web