Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303592

[PATCHv3 06/13] perf record: Store data mmaps for dwarf unwind

Show all headers | View raw

On Thu, Jan 07, 2016 at 10:14:14PM +0900, Namhyung Kim wrote:
> On Thu, Jan 07, 2016 at 01:39:28PM +0100, Jiri Olsa wrote:
> > Currently we don't synthesize data mmap by default. It depends
> > on -d option, that enables data address sampling.
> > 
> > But we've seen cases (softice) where DWARF unwinder went through
> > non executable mmaps, which we need to lookup in MAP__VARIABLE tree.
> > 
> > Making data mmaps to be synthesized for dwarf unwind as well.
> > 
> > Reported-by: Noel Grandin <noelgrandin@gmail.com>
> > Link: http://lkml.kernel.org/n/tip-lh02yir6qfycn8zr892rmlgg@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/perf/builtin-record.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index 9c5cdc2c4471..465bde77f49b 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -815,8 +815,11 @@ int record_parse_callchain_opt(const struct option *opt,
> >  	}
> >  
> >  	ret = parse_callchain_record_opt(arg, &callchain_param);
> > -	if (!ret)
> > +	if (!ret) {
> > +		/* Enable data address sampling for DWARF unwind. */
> > +		record->sample_address = true;
> 
> How does it guarantee that it enables data address sampling only for
> DWARF unwind?  Maybe you want this?
> 
> 		if (callchain_param.record_mode == CALLCHAIN_DWARF)
> 			record->sample_address = true;

ugh.. too much coofee.. :-\ third time's a charm, v3 attached

thanks,
jirka


---
Currently we don't synthesize data mmap by default. It depends
on -d option, that enables data address sampling.

But we've seen cases (softice) where DWARF unwinder went through
non executable mmaps, which we need to lookup in MAP__VARIABLE tree.

Making data mmaps to be synthesized for dwarf unwind as well.

Reported-by: Noel Grandin <noelgrandin@gmail.com>
Link: http://lkml.kernel.org/n/tip-lh02yir6qfycn8zr892rmlgg@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/builtin-record.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 9c5cdc2c4471..dc4e0adf5c5b 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -815,8 +815,12 @@ int record_parse_callchain_opt(const struct option *opt,
 	}
 
 	ret = parse_callchain_record_opt(arg, &callchain_param);
-	if (!ret)
+	if (!ret) {
+		/* Enable data address sampling for DWARF unwind. */
+		if (callchain_param.record_mode == CALLCHAIN_DWARF)
+			record->sample_address = true;
 		callchain_debug();
+	}
 
 	return ret;
 }
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 06/13] perf record: Store data mmaps for dwarf unwind Jiri Olsa <jolsa@kernel.org> - 2016-01-07 10:20 +0100
  Re: [PATCH 06/13] perf record: Store data mmaps for dwarf unwind Namhyung Kim <namhyung@kernel.org> - 2016-01-07 12:20 +0100
    [PATCHv2 06/13] perf record: Store data mmaps for dwarf unwind Jiri Olsa <jolsa@redhat.com> - 2016-01-07 13:40 +0100
      Re: [PATCHv2 06/13] perf record: Store data mmaps for dwarf unwind Namhyung Kim <namhyung@kernel.org> - 2016-01-07 14:20 +0100
        [PATCHv3 06/13] perf record: Store data mmaps for dwarf unwind Jiri Olsa <jolsa@redhat.com> - 2016-01-07 14:40 +0100
          Re: [PATCHv3 06/13] perf record: Store data mmaps for dwarf unwind Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-07 21:50 +0100
          [tip:perf/core] perf record: Store data mmaps for dwarf unwind tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-01-09 17:50 +0100

csiph-web