Re: [PATCH] kvm/s390: drop unpaired smp_mb

From	Christian Borntraeger <borntraeger@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kvm/s390: drop unpaired smp_mb
Date	2016-01-07 09:30 +0100
Message-ID	<qOe7f-5u7-1@gated-at.bofh.it> (permalink)
References	<qNCEG-5ih-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/05/2016 05:20 PM, Michael S. Tsirkin wrote:
> smp_mb on vcpu destroy isn't paired with anything, violating pairing
> rules, and seems to be useless.
> 
> Drop it.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied.
(I had to fix this up a little to match kvm/next)

Thanks

> ---
> 
> Untested.
> 
>  arch/s390/kvm/kvm-s390.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 8465892..7305d2c 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1195,7 +1195,6 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)
>  		    (__u64) vcpu->arch.sie_block)
>  			vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda = 0;
>  	}
> -	smp_mb();
> 
>  	if (kvm_is_ucontrol(vcpu->kvm))
>  		gmap_free(vcpu->arch.gmap);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kvm/s390: drop unpaired smp_mb "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-05 17:30 +0100
  Re: [PATCH] kvm/s390: drop unpaired smp_mb Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-07 09:30 +0100

csiph-web