Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303341

Re: [RFC/PATCH v2] perf report: Show random usage tip on the help line

Show all headers | View raw

On Thu, Jan 07, 2016 at 04:46:22PM +0900, Namhyung Kim wrote:

SNIP

>  
>  struct callchain_param	callchain_param = {
>  	.mode	= CHAIN_GRAPH_ABS,
> @@ -663,3 +665,28 @@ fetch_kernel_version(unsigned int *puint, char *str,
>  		*puint = (version << 16) + (patchlevel << 8) + sublevel;
>  	return 0;
>  }
> +
> +const char *perf_report_tip(const char *dirname)
> +{
> +	struct strlist *tips;
> +	struct str_node *node;
> +	char *tip = NULL;
> +	struct strlist_config conf = {
> +		.dirname = system_path(dirname) ,
> +	};
> +
> +	tips = strlist__new("tips.txt", &conf);
> +	if (tips == NULL || strlist__nr_entries(tips) == 1) {
> +		tip = (char *)"Cannot find tips.txt file";
> +		goto out;

could we also try to read "./Documentation/tips.txt" ?

so people who don't install perf and run it from 'tools/perf'
get some tips as well? ;-)

[jolsa@krava perf]$ ./perf report --stdio  | tail -3
#
# (Cannot find tips.txt file)
#
[jolsa@krava perf]$ 

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC/PATCH v2] perf report: Show random usage tip on the help line Namhyung Kim <namhyung@kernel.org> - 2016-01-07 08:50 +0100
  Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Jiri Olsa <jolsa@redhat.com> - 2016-01-07 09:10 +0100
    Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Jiri Olsa <jolsa@redhat.com> - 2016-01-07 09:20 +0100
      Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Namhyung Kim <namhyung@kernel.org> - 2016-01-07 11:50 +0100
    Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Namhyung Kim <namhyung@kernel.org> - 2016-01-07 11:50 +0100
  Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Jiri Olsa <jolsa@redhat.com> - 2016-01-07 09:10 +0100
    Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Namhyung Kim <namhyung@kernel.org> - 2016-01-07 12:00 +0100
  Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Andi Kleen <andi@firstfloor.org> - 2016-01-07 17:50 +0100
    Re: [RFC/PATCH v2] perf report: Show random usage tip on the help  line Jiri Olsa <jolsa@redhat.com> - 2016-01-07 19:20 +0100

csiph-web