Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303284

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

From "Simon Wood" <simon@mungewell.org>
Newsgroups linux.kernel
Subject Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel
Date 2016-01-07 05:30 +0100
Message-ID <qOan0-2Sc-15@gated-at.bofh.it> (permalink)
References (6 earlier) <qEcT9-Dg-41@gated-at.bofh.it> <qEerT-1tP-7@gated-at.bofh.it> <qNa5I-1L4-11@gated-at.bofh.it> <qNXpL-2lM-5@gated-at.bofh.it> <qO7Sa-XB-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, January 6, 2016 6:47 pm, Dmitry Torokhov wrote:

> It is wrong. Aside form the fact that IMO xpad.c is the wrong place for
> this code to be in, why are we waiting for the input device to be opened by
> userspace before we do the switch instead of doing it immediately?

The 'send magic' might be better in a probe() call, but I don't believe
that it requires userspace interaction as it stands. The wheel will
disconnect almost immediately without me doing anything other than plug it
in.
--
Jan  6 21:18:50 speedster kernel: [  439.604037] usb 5-1: new full-speed
USB device number 2 using uhci_hcd
Jan  6 21:18:50 speedster kernel: [  439.791153] usb 5-1: New USB device
found, idVendor=046d, idProduct=c261
Jan  6 21:18:50 speedster kernel: [  439.791160] usb 5-1: New USB device
strings: Mfr=1, Product=2, SerialNumber=3
Jan  6 21:18:50 speedster kernel: [  439.791164] usb 5-1: Product: G920
Driving Force Racing Wheel for Xbox One
Jan  6 21:18:50 speedster kernel: [  439.791167] usb 5-1: Manufacturer:
Logitech
Jan  6 21:18:50 speedster kernel: [  439.791170] usb 5-1: SerialNumber:
00005d1d5129cebe
Jan  6 21:18:50 speedster mtp-probe: checking bus 5, device 2:
"/sys/devices/pci0000:00/0000:00:1d.3/usb5/5-1"
Jan  6 21:18:50 speedster mtp-probe: bus: 5, device: 2 was not an MTP device
Jan  6 21:18:51 speedster kernel: [  440.815191] input: Logitech G920
Driving Force Racing Wheel as
/devices/pci0000:00/0000:00:1d.3/usb5/5-1/5-1:1.0/input/input4
Jan  6 21:18:51 speedster kernel: [  440.815310] usbcore: registered new
interface driver xpad
Jan  6 21:18:52 speedster kernel: [  441.340093] usb 5-1: USB disconnect,
device number 2
Jan  6 21:18:52 speedster kernel: [  442.052037] usb 5-1: new full-speed
USB device number 3 using uhci_hcd
Jan  6 21:18:52 speedster kernel: [  442.239129] usb 5-1: New USB device
found, idVendor=046d, idProduct=c262
Jan  6 21:18:52 speedster kernel: [  442.239136] usb 5-1: New USB device
strings: Mfr=1, Product=2, SerialNumber=3
Jan  6 21:18:52 speedster kernel: [  442.239139] usb 5-1: Product: G920
Driving Force Racing Wheel for Xbox One
Jan  6 21:18:52 speedster kernel: [  442.239142] usb 5-1: Manufacturer:
Logitech
Jan  6 21:18:52 speedster kernel: [  442.239145] usb 5-1: SerialNumber:
00005d1d5129cebe
Jan  6 21:18:52 speedster mtp-probe: checking bus 5, device 3:
"/sys/devices/pci0000:00/0000:00:1d.3/usb5/5-1"
Jan  6 21:18:52 speedster mtp-probe: bus: 5, device: 3 was not an MTP device
Jan  6 21:18:52 speedster kernel: [  442.267248] input: Logitech G920
Driving Force Racing Wheel for Xbox One as
/devices/pci0000:00/0000:00:1d.3/usb5/5-1/5-1:1.0/0003:046D:C262.0002/input/input5
Jan  6 21:18:52 speedster kernel: [  442.267510] logitech-hidpp-device
0003:046D:C262.0002: input,hiddev0,hidraw1: USB HID v1.11 Joystick
[Logitech G920 Driving Force Racing Wheel for Xbox One] on
usb-0000:00:1d.3-1/input0
Jan  6 21:18:53 speedster kernel: [  442.322160] logitech-hidpp-device
0003:046D:C262.0002: HID++ 4.2 device connected.
--

I also did a quick check with the 'send magic' disabled. Xpad creates the
js0 and populates buttons, but pressing buttons/turning wheel does not
result in any change in js0.

I don't disagree to it being a seperate module, but don't have the time to
implement/test at the moment. If some else does that would be good, can we
make sure that the kconfig/makefile stuff uses same/sensible HID_CONFIGs?
Simon


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-01-04 11:00 +0100
  Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel madcatxster@devoid-pointer.net - 2016-01-04 13:50 +0100
  Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-05 02:10 +0100
  Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel Jiri Kosina <jikos@kernel.org> - 2016-01-06 15:40 +0100
    Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-07 02:50 +0100
      Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel "Simon Wood" <simon@mungewell.org> - 2016-01-07 05:30 +0100
      Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel Michal Malý <madcatxster@devoid-pointer.net> - 2016-01-08 00:00 +0100
        Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-08 00:00 +0100
          Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel Michal Malý <madcatxster@devoid-pointer.net> - 2016-01-08 00:10 +0100
      Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech  G920 Wheel Jiri Kosina <jikos@kernel.org> - 2016-01-08 10:20 +0100

csiph-web