[PATCH RESEND] perf tools: bug fix, an error of parsing 'man.<tool>.*' config variable.

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Taeung Song <treeze.taeung@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH RESEND] perf tools: bug fix, an error of parsing 'man.<tool>.*' config variable.
Date	Thu, 07 Jan 2016 05:10:01 +0100
Message-ID	<qOa3D-2Ha-1@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=pVv3dOU8mtWLWlQjtlnlCFaW9BzjuCZ/XbdBnc+HXvE=; b=GanXI3lecorsOut1QSeY+dk5LvtOsM3FGIilKuwtITJHBVa+cubP49nhqGp5Gowuzf z90zGGD0MivaZhe4Tv+owjshNkvoXi4Zl3gj2ZUFiHTDYWSAqpYoonnFjrdFPrDfVvzx PD48RDoXgnQeQcYfvkYeB2GQbe/KvQEM/E+5fyzP1cc/x/MeLuOs/jsmGSJOHPVr2KzW WgYt4nEU+leLWkwZ57ZPD0aK3K/SoPCcGVAU/WkHgwOkXBjjbNu/KkG6qTBhkSuR0EDq nky/wjMhVMIWCngNe+75Sd11eKksvGOTHN2zXgYoprjJdDEMKPACQ4fCbrRpJdtcRZnl wFSQ==
X-Received	by 10.66.100.135 with SMTP id ey7mr149474616pab.108.1452139586113; Wed, 06 Jan 2016 20:06:26 -0800 (PST)
X-Mailer	git-send-email 2.5.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>, Taeung Song <treeze.taeung@gmail.com>, Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>
X-Original-Date	Thu, 7 Jan 2016 13:00:51 +0900
X-Original-Message-ID	<1452139251-23725-1-git-send-email-treeze.taeung@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1303276

Show key headers only | View raw

To add new man viewer, configs like 'man.<tool>.cmd',
'man.<tool>.path' can be set into config file (~/.perfconfig).
But parsing config file is stopped because the config variable
contains '.' character i.e.

If setting 'man.xman.cmd' into config file,

[man]
        gman.cmd = gman

when launching perf an error message is printed like below.

Fatal: bad config file line 11 in /home/taeung/.perfconfig

So modify iskeychar() function to decide '.' character
as key character parsing config file.

Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/util/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index d3e12e3..3c01ced 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -122,7 +122,7 @@ static char *parse_value(void)
 
 static inline int iskeychar(int c)
 {
-	return isalnum(c) || c == '-' || c == '_';
+	return isalnum(c) || c == '-' || c == '_' || c == '.';
 }
 
 static int get_value(config_fn_t fn, void *data, char *name, unsigned int len)
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] perf tools: bug fix, an error of parsing 'man.<tool>.*' config variable. Taeung Song <treeze.taeung@gmail.com> - 2016-01-07 05:10 +0100
  Re: [PATCH RESEND] perf tools: bug fix, an error of parsing  'man.<tool>.*' config variable. Namhyung Kim <namhyung@kernel.org> - 2016-01-07 09:10 +0100

csiph-web