Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices

From	Wan Zongshun <vw@iommu.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices
Date	2016-01-09 11:10 +0100
Message-ID	<qOYD7-40S-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <qOhy9-7Vb-15@gated-at.bofh.it> <qOvKO-Iq-7@gated-at.bofh.it> <qOEbo-6yE-29@gated-at.bofh.it> <qOII3-1k3-19@gated-at.bofh.it> <qOII3-1k3-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


-------- Original Message --------
> On Fri, Jan 08, 2016 at 10:52:59PM +0800, Wan Zongshun wrote:
>> Actually I am supposing the '.add_device' will be the first called
>> in iommu initializing stage, so I think as long as having no error
>> of check device here, any call-sites of get_device_id() will be
>> fine, because adding device successfully should be the pre-condition
>> of any iommu function can be performed, please correct me.
>>
>> static int amd_iommu_add_device(struct device *dev)
>> {
>> 	struct iommu_dev_data *dev_data;
>> 	struct iommu_domain *domain;
>> 	struct amd_iommu *iommu;
>> 	u16 devid;
>> 	int ret;
>>
>> 	if (!check_device(dev) || get_dev_data(dev))
>> 		return 0;
>>
>> 	devid = get_device_id(dev);
>> 	iommu = amd_iommu_rlookup_table[devid];
>
> There are places in the interrupt remapping code that call get_device_id
> without calling check_device first. See get_irq_domain and get_devid.
>

Okay, I will change this get_device_id return to int, and judge this 
return value in caller of this function like get_devid style.

If so we will modify some existing amd iommu driver codes, and Can I 
merge those into this patch 5/6? or I will create another dedicated 
patch to take this action?

Vincent.

>
> 	Joerg
>
>

Thread

Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices Joerg Roedel <joro@8bytes.org> - 2016-01-07 13:10 +0100
  Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices Wan ZongShun <mcuos.com@gmail.com> - 2016-01-08 04:20 +0100
    Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices Joerg Roedel <joro@8bytes.org> - 2016-01-08 13:20 +0100
      Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices Joerg Roedel <joro@8bytes.org> - 2016-01-08 18:10 +0100
        Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices Wan Zongshun <vw@iommu.org> - 2016-01-09 11:10 +0100
      Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices Wan Zongshun <vw@iommu.org> - 2016-01-08 19:10 +0100

csiph-web