Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305107

[PATCH v4.4-rc8] iio: magnetometer: ak8975: Silence 'may be used uninitialized' warning

Show all headers | View raw

From: Tim Gardner <tim.gardner@canonical.com>

drivers/iio/magnetometer/ak8975.c: In function 'ak8975_probe':
drivers/iio/magnetometer/ak8975.c:788:14: warning: 'chipset' may be used uninitialized in this function [-Wmaybe-uninitialized]
  data->def = &ak_def_array[chipset];

gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1)

Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---

This seems like a legitimate warning, though gcc should have complained
about an earlier use of chipset on line 782.

 drivers/iio/magnetometer/ak8975.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index b13936d..80ec0ce 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -732,7 +732,7 @@ static int ak8975_probe(struct i2c_client *client,
 	int eoc_gpio;
 	int err;
 	const char *name = NULL;
-	enum asahi_compass_chipset chipset;
+	enum asahi_compass_chipset chipset = AK_MAX_TYPE;
 
 	/* Grab and set up the supplied GPIO. */
 	if (client->dev.platform_data)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v4.4-rc8] iio: magnetometer: ak8975: Silence 'may be used uninitialized' warning tim.gardner@canonical.com - 2016-01-09 01:20 +0100
  Re: [PATCH v4.4-rc8] iio: magnetometer: ak8975: Silence 'may be used  uninitialized' warning Jonathan Cameron <jic23@kernel.org> - 2016-01-09 17:10 +0100
    Re: [PATCH v4.4-rc8] iio: magnetometer: ak8975: Silence 'may be  used uninitialized' warning Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-01-09 17:20 +0100
      Re: [PATCH v4.4-rc8] iio: magnetometer: ak8975: Silence 'may be used  uninitialized' warning Jonathan Cameron <jic23@kernel.org> - 2016-01-09 17:30 +0100
        Re: [PATCH v4.4-rc8] iio: magnetometer: ak8975: Silence 'may be  used uninitialized' warning Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-01-09 18:00 +0100
          Re: [PATCH v4.4-rc8] iio: magnetometer: ak8975: Silence 'may be used  uninitialized' warning Jonathan Cameron <jic23@kernel.org> - 2016-01-09 18:00 +0100

csiph-web