Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1305092

Re: [RFC 11/13] x86/mm: Build arch/x86/mm/tlb.c even on !SMP

From Dave Hansen <dave.hansen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [RFC 11/13] x86/mm: Build arch/x86/mm/tlb.c even on !SMP
Date 2016-01-09 01:00 +0100
Message-ID <qOP6N-5zU-1@gated-at.bofh.it> (permalink)
References <qOOu6-5ka-5@gated-at.bofh.it> <qOOu7-5ka-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 01/08/2016 03:15 PM, Andy Lutomirski wrote:
> @@ -352,3 +354,5 @@ static int __init create_tlb_single_page_flush_ceiling(void)
>  	return 0;
>  }
>  late_initcall(create_tlb_single_page_flush_ceiling);
> +
> +#endif /* CONFIG_SMP */

Heh, I was about to complain that you #ifdef'd out my lovely INVLPG
tunable.  But I guess on UP you just get flush_tlb_mm_range() from:

> static inline void flush_tlb_mm_range(struct mm_struct *mm,
>            unsigned long start, unsigned long end, unsigned long vmflag)
> {
>         if (mm == current->active_mm)
>                 __flush_tlb_up();
> }

which doesn't even do INVLPG.  How sad.  Poor UP.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[RFC 11/13] x86/mm: Build arch/x86/mm/tlb.c even on !SMP Andy Lutomirski <luto@kernel.org> - 2016-01-09 00:20 +0100
  Re: [RFC 11/13] x86/mm: Build arch/x86/mm/tlb.c even on !SMP Dave Hansen <dave.hansen@linux.intel.com> - 2016-01-09 01:00 +0100

csiph-web