[PATCH] kconfig: fix qconf segfault by deleting heap objects

From	Chris Bainbridge <chris.bainbridge@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] kconfig: fix qconf segfault by deleting heap objects
Date	2016-01-08 21:50 +0100
Message-ID	<qOM8V-3B5-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

On Debian stable (qt-4.8.6) 'make xconfig' intermittently fails due to
qconf segfaulting at exit time in QXcbEventReader. The cause of this is
destructors on the heap objects never being called, so fix this by
properly deleting the heap objects before exit.

Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com>
---
Trivial error, as described at https://forum.qt.io/topic/26658/solved-segfault-on-qapplication-exit
---
 scripts/kconfig/qconf.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 91b7e6fbc364..fc5555992220 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1863,6 +1863,8 @@ int main(int ac, char** av)
 
 	configSettings->endGroup();
 	delete configSettings;
+	delete v;
+	delete configApp;
 
 	return 0;
 }
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] kconfig: fix qconf segfault by deleting heap objects Chris Bainbridge <chris.bainbridge@gmail.com> - 2016-01-08 21:50 +0100
  Re: [PATCH] kconfig: fix qconf segfault by deleting heap objects Michal Marek <mmarek@suse.cz> - 2016-01-11 09:50 +0100

csiph-web