Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304968

Re: [PATCH v4.4-rc8 v3] dmaengine: ioatdma: Squelch framesize warnings

Show all headers | View raw

On Fri, 2016-01-08 at 19:41 +0000, Williams, Dan J wrote:
> On Fri, Jan 8, 2016 at 11:25 AM,  <tim.gardner@canonical.com> wrote:
> > From: Tim Gardner <tim.gardner@canonical.com>
> > 
> >   CC [M]  drivers/dma/ioat/prep.o
> > drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor':
> > drivers/dma/ioat/prep.c:682:1: warning: the frame size of 1048
> > bytes is larger than 1024 bytes [-Wframe-larger-than=]
> >  }
> >  ^
> > drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor_val':
> > drivers/dma/ioat/prep.c:714:1: warning: the frame size of 1048
> > bytes is larger than 1024 bytes [-Wframe-larger-than=]
> >  }
> > 
> > gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1)
> > 
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Prarit Bhargava <prarit@redhat.com>
> > Cc: Nicholas Mc Guire <der.herr@hofr.at>
> > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> > ---
> > 
> > v2 - use per CPU static buffers instead of dynamically allocating
> > memory.
> > v3 - Use get_cpu_var/put_cpu_var which implicitly control
> > preeemption. Drop
> >      the wrapper function that no longer serves any purpose.
> > 
> >  drivers/dma/ioat/prep.c | 29 +++++++++++++++++++++++++----
> >  1 file changed, 25 insertions(+), 4 deletions(-)
> 
> Looks good to me... but now that I think about it, why is MAX_SCF set
> to 1024 in the first place?  Certainly it can't be bigger than the
> maximum number of sources in a single operation which is 8 to 16.
> Even md raid can only support up to 256 devices in an array.  So I
> think that contstant is bogus.
> 
> If we set it to 16 we may not even need the percpu change.
> 
> Dave?

You are right. It was an arbitrary number I threw in there to address
sparse warning. It can be reduced. 256 seems reasonable. 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4.4-rc8] dmaengine: ioatdma: Squelch framesize warnings tim.gardner@canonical.com - 2016-01-07 19:10 +0100
  Re: [PATCH v4.4-rc8] dmaengine: ioatdma: Squelch framesize warnings Dan Williams <dan.j.williams@intel.com> - 2016-01-07 20:50 +0100
  [PATCH v4.4-rc8 v2] dmaengine: ioatdma: Squelch framesize warnings tim.gardner@canonical.com - 2016-01-08 14:40 +0100
    Re: [PATCH v4.4-rc8 v2] dmaengine: ioatdma: Squelch framesize warnings Dan Williams <dan.j.williams@intel.com> - 2016-01-08 17:40 +0100
      [PATCH v4.4-rc8 v3] dmaengine: ioatdma: Squelch framesize warnings tim.gardner@canonical.com - 2016-01-08 20:30 +0100
        Re: [PATCH v4.4-rc8 v3] dmaengine: ioatdma: Squelch framesize warnings Dan Williams <dan.j.williams@intel.com> - 2016-01-08 20:50 +0100
          Re: [PATCH v4.4-rc8 v3] dmaengine: ioatdma: Squelch framesize  warnings "Jiang, Dave" <dave.jiang@intel.com> - 2016-01-08 21:00 +0100
            [PATCH v4.4-rc8 v4] dmaengine: ioatdma: Squelch framesize warnings tim.gardner@canonical.com - 2016-01-08 22:50 +0100
              Re: [PATCH v4.4-rc8 v4] dmaengine: ioatdma: Squelch framesize  warnings Vinod Koul <vinod.koul@intel.com> - 2016-01-13 14:30 +0100

csiph-web