Re: [PATCH 09/23] hisi_sas: add v2 hw init

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/23] hisi_sas: add v2 hw init
Date	2016-01-08 16:10 +0100
Message-ID	<qOGPU-8rM-23@gated-at.bofh.it> (permalink)
References	<qOFTQ-7OQ-3@gated-at.bofh.it> <qOFTT-7OQ-65@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 08, 2016 at 10:15:28PM +0800, John Garry wrote:

> +	/* Global registers init*/
> +	if (of_get_property(np, "am-max-trans", NULL)) {
> +		hisi_sas_write32(hisi_hba, AM_CFG_MAX_TRANS, 0x2020);
> +		hisi_sas_write32(hisi_hba, AM_CFG_SINGLE_PORT_MAX_TRANS,
> +				 0x2020);
> +	}

Use of_property_read_bool for boolean properties like this.

I still don't follow exactly what this property means, and why it is
necessary, but that's an issue for the binding document.

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 09/23] hisi_sas: add v2 hw init John Garry <john.garry@huawei.com> - 2016-01-08 15:10 +0100
  Re: [PATCH 09/23] hisi_sas: add v2 hw init Mark Rutland <mark.rutland@arm.com> - 2016-01-08 16:10 +0100

csiph-web