Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1304537
| From | Xunlei Pang <xlpang@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres() |
| Date | 2016-01-08 14:30 +0100 |
| Message-ID | <qOFha-7jI-29@gated-at.bofh.it> (permalink) |
| References | <qOv85-7I-1@gated-at.bofh.it> <qOv85-7I-3@gated-at.bofh.it> <qOAUa-4eB-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 01/08/2016 at 04:47 PM, Minfei Huang wrote:
> On 01/08/16 at 10:33am, Xunlei Pang wrote:
>> +
>> +static int
>> +kexec_mark_range(unsigned long start, unsigned long end, bool protect)
>> +{
>> + struct page *page;
>> + unsigned int nr_pages;
>> +
>> + /* For physical range: [start, end] */
>> + if (!end || start > end)
>> + return 0;
> This test !end is hard to be understood without the annotation. It is
> better to add the comment about it.
!end is just for uninitialized crashk resource with a zero end member,
maybe not so hard to understand :-)
Regards,
Xunlei
>
> Otherwise it looks good for me.
>
> Thanks
> Minfei
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 1/2] kexec: Introduce a protection mechanism for the crashkernel reserved memory Xunlei Pang <xlpang@redhat.com> - 2016-01-08 03:40 +0100
[PATCH v3 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres() Xunlei Pang <xlpang@redhat.com> - 2016-01-08 03:40 +0100
Re: [PATCH v3 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres() Minfei Huang <mhuang@redhat.com> - 2016-01-08 09:50 +0100
Re: [PATCH v3 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres() Xunlei Pang <xlpang@redhat.com> - 2016-01-08 14:30 +0100
Re: [PATCH v3 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres() Minfei Huang <mhuang@redhat.com> - 2016-01-10 02:10 +0100
csiph-web