Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304289

Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c
Date 2016-01-08 10:10 +0100
Message-ID <qOBdw-4AJ-13@gated-at.bofh.it> (permalink)
References <qOsjT-6Hv-9@gated-at.bofh.it> <qOsjU-6Hv-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Friday 08 January 2016 02:34:29 Yury Norov wrote:
> +
> +#include "../../../fs/compat_binfmt_elf.c"
> 

This is the wrong file, you have to include fs/binfmt_elf.c, otherwise
you pick up the same definitions that you have for the other one.

Alternatively, you can also change binfmt_elf32.c to include fs/binfmt_elf.c
and use fs/compat_binfmt_elf.c here if that makes the code nicer, you
just can use the compat file for both or things get ugly because of
the extra indirections.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov <ynorov@caviumnetworks.com> - 2016-01-08 00:40 +0100
  Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov <ynorov@caviumnetworks.com> - 2016-01-08 00:50 +0100
  Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Arnd Bergmann <arnd@arndb.de> - 2016-01-08 10:10 +0100
    Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov <ynorov@caviumnetworks.com> - 2016-01-12 17:50 +0100
      Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Arnd Bergmann <arnd@arndb.de> - 2016-01-13 00:10 +0100

csiph-web