RE: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A

From	"Yang, Wenyou" <Wenyou.Yang@atmel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A
Date	2016-01-08 09:00 +0100
Message-ID	<qOA7M-3BQ-7@gated-at.bofh.it> (permalink)
References	<qOuOJ-8qz-1@gated-at.bofh.it> <qOuOL-8qz-29@gated-at.bofh.it> <qOwnw-Yw-19@gated-at.bofh.it> <qOz22-2Tw-3@gated-at.bofh.it> <qOzlo-3id-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:k.kozlowski@samsung.com]
> Sent: 2016年1月8日 15:03
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Sebastian Reichel <sre@kernel.org>; Dmitry Eremin-Solenikov
> <dbaryshkov@gmail.com>; David Woodhouse <dwmw2@infradead.org>; Rob
> Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark
> Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>;
> Kumar Gala <galak@codeaurora.org>; Ferre, Nicolas
> <Nicolas.FERRE@atmel.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; linux-pm@vger.kernel.org
> Subject: Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A
> 
> On 08.01.2016 15:43, Yang, Wenyou wrote:
> 
> [...]
> 
> >>> +static struct platform_driver act8945a_charger_driver = {
> >>> +       .driver = {
> >>> +               .name = "act8945a-charger",
> >>> +       },
> >>> +       .probe  = act8945a_charger_probe,
> >>> +       .remove = act8945a_charger_remove, };
> >>> +
> >>> +static int __init act8945a_charger_init(void) {
> >>> +       return platform_driver_register(&act8945a_charger_driver);
> >>> +}
> >>> +subsys_initcall(act8945a_charger_init);
> >>
> >> Why subsys_initcall? This should be regular module_platform_driver.
> >
> > I want it to register early enough as MFD.  Maybe I am wrong.
> 
> No, you shouldn't manually order the probing by initcalls. This should be
> registered as usual and, if needed, support deferred probing. In this case I even
> can't find any reason to register it earlier than usual.

OK, I will change it.

Thanks.

Best Regards,
Wenyou Yang

Thread

[PATCH 0/2] power: act8945a: add charger driver for the sub-device of ACT8945A MFD Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-08 03:20 +0100
  [PATCH 2/2] power: add documentation for ACT8945A's charger DT bindings Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-08 03:20 +0100
  [PATCH 1/2] power: act8945a: add charger driver for ACT8945A Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-08 03:20 +0100
    Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-08 05:00 +0100
      RE: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-08 07:50 +0100
        Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-08 08:10 +0100
          RE: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-08 09:00 +0100
    Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-08 16:10 +0100
      RE: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-12 09:30 +0100
        Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-12 15:10 +0100

csiph-web