Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count()
Date	2016-01-07 02:50 +0100
Message-ID	<qO7Sa-XB-9@gated-at.bofh.it> (permalink)
References	<qO7p7-KS-3@gated-at.bofh.it> <qO7p7-KS-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 06, 2016 at 05:12:47PM -0800, Stephen Boyd wrote:
> A recent patch added calls to of_irq_count() in the qcom pinctrl
> drivers and that caused module build failures because
> of_irq_count() is not an exported symbol. We shouldn't export
> of_irq_count() to modules because it's an internal OF API that
> shouldn't be used by drivers. Platform drivers should use
> platform device APIs instead. Therefore, add a platform_irq_count()
> API that mirrors the of_irq_count() API so that platform drivers
> can stay DT agnostic.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Andy Gross <andy.gross@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>  drivers/base/platform.c         | 20 ++++++++++++++++++++
>  include/linux/platform_device.h |  1 +
>  2 files changed, 21 insertions(+)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/3] driver-core: platform: Add platform_irq_count() Stephen Boyd <sboyd@codeaurora.org> - 2016-01-07 02:20 +0100
  Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count() Rob Herring <robh+dt@kernel.org> - 2016-01-07 02:20 +0100
  Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-01-07 02:50 +0100
  Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count() Linus Walleij <linus.walleij@linaro.org> - 2016-01-07 10:40 +0100
  Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count() Arnd Bergmann <arnd@arndb.de> - 2016-01-07 11:40 +0100

csiph-web