Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303083

[PATCH 6/6] wireless:libertas: fix suspend problems

Show all headers | View raw

When the device goes to suspend mode with powersaving enabled,
lbs_remove_card tries to exit powersaving state even
when already woken up. That command is not processed properly in
that situation, so the system hangs at suspend,
so disable it.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/net/wireless/libertas/main.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c
index 8079560..b35b8bc 100644
--- a/drivers/net/wireless/libertas/main.c
+++ b/drivers/net/wireless/libertas/main.c
@@ -1060,7 +1060,12 @@ void lbs_remove_card(struct lbs_private *priv)
 
 	if (priv->psmode == LBS802_11POWERMODEMAX_PSP) {
 		priv->psmode = LBS802_11POWERMODECAM;
-		lbs_set_ps_mode(priv, PS_MODE_ACTION_EXIT_PS, true);
+		/* no need to wakeup if already woken up,
+		 * on suspend, this exit ps command is not processed
+		 * the driver hangs
+		 */
+		if (priv->psstate != PS_STATE_FULL_POWER)
+			lbs_set_ps_mode(priv, PS_MODE_ACTION_EXIT_PS, true);
 	}
 
 	if (priv->is_deep_sleep) {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] wireless:libertas: ieee80211 powersave mode  Andreas Kemnade <andreas@kemnade.info> - 2016-01-06 22:10 +0100
  [PATCH 3/6] wireless:libertas: add an cfg80211 interface for powersaving Andreas Kemnade <andreas@kemnade.info> - 2016-01-06 22:10 +0100
  [PATCH 5/6] wireless:libertas: go back to ps mode without commands pending Andreas Kemnade <andreas@kemnade.info> - 2016-01-06 22:10 +0100
  [PATCH 6/6] wireless:libertas: fix suspend problems Andreas Kemnade <andreas@kemnade.info> - 2016-01-06 22:10 +0100
  [PATCH 4/6] wireless:libertas: do not confirm sleep if commands are pending Andreas Kemnade <andreas@kemnade.info> - 2016-01-06 22:10 +0100

csiph-web