Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1303018
| From | Rob Herring <robh+dt@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery |
| Date | 2016-01-06 20:40 +0100 |
| Message-ID | <qO265-5si-7@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <qNyB4-2yO-9@gated-at.bofh.it> <qNJwt-1rW-7@gated-at.bofh.it> <qNR10-6zh-9@gated-at.bofh.it> <qNRDJ-71N-9@gated-at.bofh.it> <qNXpM-2lM-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jan 6, 2016 at 8:36 AM, Nishanth Menon <nm@ti.com> wrote:
> On 01/06/2016 02:13 AM, Laxman Dewangan wrote:
>>
>> On Wednesday 06 January 2016 01:12 PM, H. Nikolaus Schaller wrote:
>>> Hi,
>>>
>>> Am 06.01.2016 um 00:40 schrieb Nishanth Menon <nm@ti.com>:
>>>
>>>> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote:
>>>>> + rtc {
>>>>> + compatible = "ti,palmas-rtc";
>>>>> + interrupt-parent = <&palmas>;
>>>>> + interrupts = <8 IRQ_TYPE_NONE>;
>>>> IRQ_TYPE_NONE is not correct here -> it should have some polarity - if
>>>> it had none, there'd be no interrupt, right?
>>> Well, it just translates IRQ_TYPE_NONE through
>>>
>>> Linux/include/dt-bindings/interrupt-controller/irq.h
>>>
>>> to
>>>
>>> interrupts = <8 0>;
>>>
>>> which is given as an example in
>>>
>>> Documentation//devicetree/bindings/rtc/rtc-palmas.txt
>>>
>>> Since I don't know anything about the rtc driver beyond the bindings
>>> documentation I assume it is correct...
>>> I have added Laxman Dewangan because he introduced this interrupts =
>>> <8 0>;
>>>
>>
>> As this is for palmas interrupt controller, it does not use the second
>> field for interrupt from RTC.
>> So there is no really any polarity. It can be set to 0.
>>
>> The second argument will be used for GPIOs mainly. However, support need
>> to be added on GPIO driver for rising/falling configuration.
>
>
> Device tree represents the hardware - not to reflect how the driver
> works. if the driver is wrong, fix it. the interrupt polarity needs to
> be described in DT. based on palmas like designs, you should probably
> use IRQ_TYPE_EDGE_FALLING because that is the default signaling inside
> the SoC as it reaches Secondary interrupt handlers(SIH) registers.
If the trigger type is not programmable, then not setting the trigger
type in the DT is fine. Internal connections are often not documented.
Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-05 13:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-06 00:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-06 02:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-06 09:20 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-06 17:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-06 18:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-08 19:00 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-08 19:20 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-08 19:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-08 20:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-08 20:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-11 21:30 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-12 01:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-12 14:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-12 22:30 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-12 22:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-12 23:20 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-13 11:30 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-13 16:00 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-13 16:20 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-13 17:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-13 18:20 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-13 18:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-13 19:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-13 19:30 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-13 18:30 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-13 19:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-13 19:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-13 19:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-13 20:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-13 20:30 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-13 20:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <menon.nishanth@gmail.com> - 2016-01-13 23:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Keerthy <a0393675@ti.com> - 2016-01-14 11:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-14 18:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-14 19:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-13 19:10 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-13 19:20 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Tony Lindgren <tony@atomide.com> - 2016-01-06 17:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-01-06 08:50 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-06 09:30 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-06 15:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Rob Herring <robh+dt@kernel.org> - 2016-01-06 20:40 +0100
Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Nishanth Menon <nm@ti.com> - 2016-01-06 21:00 +0100
csiph-web