Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision"

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision"
Date	2016-01-05 12:40 +0100
Message-ID	<qNy82-1t7-21@gated-at.bofh.it> (permalink)
References	<pJlbz-4yD-5@gated-at.bofh.it> <qJjqV-29P-7@gated-at.bofh.it> <qKNdg-7Dj-7@gated-at.bofh.it> <qKOsG-8lW-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 28 December 2015 23:27:17 Arnd Bergmann wrote:
> On Monday 28 December 2015 13:01:22 Frank Rowand wrote:
> > 
> > Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revision"
> > property.
> > 
> > If the use of /revision is limited to being a location to hold an ATAG
> > value to pass to the global variable system_rev, then it would make
> > sense to just copy directly from the ATAG value into system_rev in the
> > same board file where you are copying the ATAGs.
> 
> Agreed. That would be simpler, and avoid a situation where someone relies
> on the /revision property in DT to be set from the atags compat code
> (preventing an upgrade to a newer bootloader), or on the system_rev variable
> to be the same across multiple boot loaders, in the absence of other
> kernel code setting it.

So, set system_rev only for Nokia N900? At same place where is called
save_atags()?

-- 
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Pali Rohár <pali.rohar@gmail.com> - 2016-01-05 12:40 +0100
  Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Arnd Bergmann <arnd@arndb.de> - 2016-01-05 12:50 +0100

csiph-web