Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size
Date	2016-01-05 11:20 +0100
Message-ID	<qNwSC-GU-5@gated-at.bofh.it> (permalink)
References	(5 earlier) <qLnJL-6t0-3@gated-at.bofh.it> <qLpse-7lJ-3@gated-at.bofh.it> <qLpLA-7Id-9@gated-at.bofh.it> <qLrNo-vU-37@gated-at.bofh.it> <qLzBg-5Cq-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 31, 2015 at 08:46:36AM +0800, Qu Wenruo wrote:
> > Let me note that a good reputation is also built from patch reviews
> > (hint hint).
> 
> I must admit I'm a bad reviewer.
> As when I review something, I always has an eager to rewrite part or all 
> the patch to follow my idea, even it's just a choice between different 
> design.

Yeah that's natural, but even if one does not completely agree, it's
still possible to verify that the implementation is correct.

The reviews also help to find and share some common style of
implementation so the maintainers don't scream when they see a patch and
developers and are not suprised that the patches take several rounds.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size David Sterba <dsterba@suse.cz> - 2016-01-05 11:20 +0100

csiph-web