Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

From	Helmut Schaa <helmut.schaa@googlemail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits
Date	2016-01-05 11:20 +0100
Message-ID	<qNwSC-GU-25@gated-at.bofh.it> (permalink)
References	<qN8dA-yT-7@gated-at.bofh.it> <qNgEb-609-33@gated-at.bofh.it> <qNoBI-390-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 5, 2016 at 2:27 AM, Jia-Ju Bai <baijiaju1990@163.com> wrote:
> On 01/05/2016 12:50 AM, Helmut Schaa wrote:
>>
>> On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai<baijiaju1990@163.com>  wrote:
>>>
>>> The driver calls pci_set_mwi to enable memory-write-invalidate when it
>>> is initialized, but does not call pci_clear_mwi when it is removed. Many
>>> other drivers calls pci_clear_mwi when pci_set_mwi is called, such as
>>> r8169, 8139cp and e1000.
>>>
>>> This patch adds pci_clear_mwi in error handling and removal procedure,
>>> which can fix the problem.
>>>
>>> Signed-off-by: Jia-Ju Bai<baijiaju1990@163.com>
>>
>> Looks good to me.
>> Does this fix any actual issue?
>> If yes it might we worth to mention it in the commit message.
>> Helmut
>>
>
> Lacking pci_clear_mwi may cause a resource-release omission,
> but this omission may not cause obvious issues.
> For reliability, it is better to add pci_clear_mwi in the driver.
> Many other drivers do so, such as r8169, 8139cp and e1000.

Thanks for clarification, fine with me then.

Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits Jia-Ju Bai <baijiaju1990@163.com> - 2016-01-04 09:00 +0100
  Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the  driver exits Helmut Schaa <helmut.schaa@googlemail.com> - 2016-01-04 18:00 +0100
    Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver  exits Jia-Ju Bai <baijiaju1990@163.com> - 2016-01-05 02:30 +0100
      Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the  driver exits Helmut Schaa <helmut.schaa@googlemail.com> - 2016-01-05 11:20 +0100

csiph-web