Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301193

Re: [PATCH v9 06/13] task_isolation: add debug boot flag

Show all headers | View raw

On 1/4/2016 5:52 PM, Steven Rostedt wrote:
> On Mon, 4 Jan 2016 14:34:44 -0500
> Chris Metcalf<cmetcalf@ezchip.com>  wrote:
>
>
>> >+#ifdef CONFIG_TASK_ISOLATION
>> >+void task_isolation_debug(int cpu)
>> >+{
>> >+	struct task_struct *p;
>> >+
>> >+	if (!task_isolation_possible(cpu))
>> >+		return;
>> >+
>> >+	rcu_read_lock();
> What's the rcu_read_lock() for? I don't see what is being protected by
> rcu here?

I'm not completely clear either, but this is the same idiom as is used throughout
kernel/sched/core.c when mapping from a pid or a cpu to a task_struct, since
obviously you could end up racing with the task_struct being removed after the
task dies.  My best understanding is that the rcu_read_lock() holds up the final
free of the structure so that we have time here to get another reference to it.

See for example sched_setaffinity() for a similar use of the idiom.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v9 06/13] task_isolation: add debug boot flag Steven Rostedt <rostedt@goodmis.org> - 2016-01-05 00:00 +0100
  Re: [PATCH v9 06/13] task_isolation: add debug boot flag Chris Metcalf <cmetcalf@ezchip.com> - 2016-01-05 00:50 +0100
    Re: [PATCH v9 06/13] task_isolation: add debug boot flag Steven Rostedt <rostedt@goodmis.org> - 2016-01-05 14:50 +0100

csiph-web