Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1301179

Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit)

From Tony Luck <tony.luck@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit)
Date 2016-01-05 00:20 +0100
Message-ID <qNmzT-1JR-1@gated-at.bofh.it> (permalink)
References <qN289-4OO-3@gated-at.bofh.it> <qN28a-4OO-15@gated-at.bofh.it> <qNc7z-3jA-87@gated-at.bofh.it> <qNh7c-6vZ-17@gated-at.bofh.it> <qNhJW-6ZN-45@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jan 4, 2016 at 10:08 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Jan 4, 2016 at 9:26 AM, Tony Luck <tony.luck@gmail.com> wrote:
>> On Mon, Jan 4, 2016 at 4:07 AM, Borislav Petkov <bp@alien8.de> wrote:

>>> Why not simply:
>>>
>>>         .long (to) - . + (bias) ;
>>>
>>> and
>>>
>>>         " .long (" #to ") - . + "(" #bias ") "\n"
>>>
>>> below and get rid of that _EXPAND_EXTABLE_BIAS()?
>>
>> Andy - this part is your code and I'm not sure what the trick is here.
>
> I don't remember.  I think it was just some preprocessor crud to force
> all the macros to expand fully before the assembler sees it.  If it
> builds without it, feel free to delete it.

The trick is definitely needed in the case of

# define _EXPAND_EXTABLE_BIAS(x) #x

Trying to expand it inline and get rid of the macro led to
horrible failure. The __ASSEMBLY__ case where the
macro does nothing isn't required ... but does provide
a certain amount of symmetry when looking at the two
versions of _ASM_EXTABLE_CLASS

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Andy Lutomirski <luto@amacapital.net> - 2016-01-04 02:30 +0100
  Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Tony Luck <tony.luck@gmail.com> - 2016-01-04 02:40 +0100
    Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a  bit) Ingo Molnar <mingo@kernel.org> - 2016-01-04 08:50 +0100
  Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a  bit) Borislav Petkov <bp@alien8.de> - 2016-01-04 13:10 +0100
    Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Tony Luck <tony.luck@gmail.com> - 2016-01-04 18:30 +0100
      Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Andy Lutomirski <luto@amacapital.net> - 2016-01-04 19:10 +0100
        Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Tony Luck <tony.luck@gmail.com> - 2016-01-04 20:00 +0100
          Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Andy Lutomirski <luto@amacapital.net> - 2016-01-04 20:10 +0100
        Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a  bit) Borislav Petkov <bp@alien8.de> - 2016-01-04 22:10 +0100
          Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Andy Lutomirski <luto@amacapital.net> - 2016-01-04 23:30 +0100
            Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a  bit) Borislav Petkov <bp@alien8.de> - 2016-01-05 00:10 +0100
              Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a  bit) Borislav Petkov <bp@alien8.de> - 2016-01-05 00:10 +0100
              Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Andy Lutomirski <luto@amacapital.net> - 2016-01-05 00:30 +0100
                Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a  bit) Borislav Petkov <bp@alien8.de> - 2016-01-05 12:30 +0100
        Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit) Tony Luck <tony.luck@gmail.com> - 2016-01-05 00:20 +0100

csiph-web