Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301124

Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast

Show all headers | View raw

2016-01-04 17:58 GMT-03:00 Alan Stern <stern@rowland.harvard.edu>:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> This patch fixes coding style issues reported by checkpatch concerning
>> to unnecessary space after a cast.
>
> This is a case where checkpatch is wrong, IMO.  Casts should always be
> followed by a space.  I will not accept this patch.
Ok. I understand.

>
> This must be something recently added to checkpatch.  It never used to
> complain about casts, whether they were followed by a space or not.
I'm using the checkpatch --strict option.

>
> Alan Stern
>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>>  drivers/usb/host/ehci-dbg.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
>> index 1645120..edae79e 100644
>> --- a/drivers/usb/host/ehci-dbg.c
>> +++ b/drivers/usb/host/ehci-dbg.c
>> @@ -123,7 +123,7 @@ dbg_qh(const char *label, struct ehci_hcd *ehci, struct ehci_qh *qh)
>>
>>       ehci_dbg(ehci, "%s qh %p n%08x info %x %x qtd %x\n", label,
>>               qh, hw->hw_next, hw->hw_info1, hw->hw_info2, hw->hw_current);
>> -     dbg_qtd("overlay", ehci, (struct ehci_qtd *) &hw->hw_qtd_next);
>> +     dbg_qtd("overlay", ehci, (struct ehci_qtd *)&hw->hw_qtd_next);
>>  }
>>
>>  static void __maybe_unused
>> @@ -491,7 +491,7 @@ static void qh_lines(
>>                               (scratch >> 16) & 0x7fff,
>>                               scratch,
>>                               td->urb,
>> -                             (u32) td->qtd_dma,
>> +                             (u32)td->qtd_dma,
>>                               hc32_to_cpup(ehci, &td->hw_buf[0]));
>>               if (size < temp)
>>                       temp = size;
>>
>



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/17] usb: host: ehci-dbg: cleanup and refactoring "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-04 21:20 +0100
  [PATCH 17/17] usb: host: ehci-dbg: refactor fill_periodic_buffer function "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-04 21:20 +0100
    Re: [PATCH 17/17] usb: host: ehci-dbg: refactor fill_periodic_buffer  function Alan Stern <stern@rowland.harvard.edu> - 2016-01-04 22:10 +0100
      Re: [PATCH 17/17] usb: host: ehci-dbg: refactor fill_periodic_buffer function "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-05 02:20 +0100
        Re: [PATCH 17/17] usb: host: ehci-dbg: refactor fill_periodic_buffer  function Alan Stern <stern@rowland.harvard.edu> - 2016-01-05 16:20 +0100
          Re: [PATCH 17/17] usb: host: ehci-dbg: refactor fill_periodic_buffer function "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-05 16:50 +0100
  [PATCH 10/17] usb: host: ehci-dbg: use a blank line after struct declarations "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-04 21:20 +0100
  [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-04 21:30 +0100
    Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space  after cast Alan Stern <stern@rowland.harvard.edu> - 2016-01-04 22:00 +0100
      Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space  after cast Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-01-04 22:50 +0100
        Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after  cast Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-01-04 23:00 +0100
          Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-04 23:10 +0100
            Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space  after cast Joe Perches <joe@perches.com> - 2016-01-05 03:50 +0100
              Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-05 16:20 +0100
              Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space  after cast Alan Stern <stern@rowland.harvard.edu> - 2016-01-05 17:50 +0100
      Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast "Geyslan G. Bem" <geyslan@gmail.com> - 2016-01-04 22:50 +0100

csiph-web