Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301103

Re: [patch] drm/amdgpu/cgs: cleanup some indenting

Show all headers | View raw

On Mon, Jan 4, 2016 at 3:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This code is indented too far.  Also we normally use spaces to align if
> statement conditions.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.  thanks!

Alex

>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> index 6fa0fea..59485d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
>         if (info->input_count > 0) {
>                 if (info->pinput_argument == NULL)
>                         return -EINVAL;
> -                       argument = info->pinput_argument;
> -                       func_no = argument->value;
> -                       for (i = 0; i < info->input_count; i++) {
> -                               if (((argument->type == ACPI_TYPE_STRING) ||
> -                                       (argument->type == ACPI_TYPE_BUFFER))
> -                                       && (argument->pointer == NULL))
> -                                       return -EINVAL;
> -                               argument++;
> -                       }
> +               argument = info->pinput_argument;
> +               func_no = argument->value;
> +               for (i = 0; i < info->input_count; i++) {
> +                       if (((argument->type == ACPI_TYPE_STRING) ||
> +                            (argument->type == ACPI_TYPE_BUFFER)) &&
> +                           (argument->pointer == NULL))
> +                               return -EINVAL;
> +                       argument++;
> +               }
>         }
>
>         if (info->output_count > 0) {
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] drm/amdgpu/cgs: cleanup some indenting Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 21:50 +0100
  Re: [patch] drm/amdgpu/cgs: cleanup some indenting Alex Deucher <alexdeucher@gmail.com> - 2016-01-04 22:20 +0100

csiph-web