Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis
Date	2016-01-04 19:40 +0100
Message-ID	<qNicW-79x-13@gated-at.bofh.it> (permalink)
References	<qGLto-32N-7@gated-at.bofh.it> <qGLto-32N-27@gated-at.bofh.it> <qMUDE-8mN-17@gated-at.bofh.it> <qNi3h-76n-21@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Mon, Jan 04, 2016 at 11:24:42AM -0700, Jason Gunthorpe wrote:
> On Sun, Jan 03, 2016 at 07:20:40PM +0200, Jarkko Sakkinen wrote:
> > On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote:
> > > Instead of clearing the global interrupts flag when any device
> > > does not have an interrupt just pass -1 through tpm_info.irq.
> > > 
> > > The only thing that asks for autoprobing is the force=1 path.
> > 
> > Sorry for my ignorance but what does this patch help? Why interrupts
> > flag is not enough?
> 
> It is wrong for a driver's probe function to change global state, and
> very wrong to change a module option.

I disagree about global state in some sense but module options should
stay static. That's much better argument.

> > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > > Tested-by: Wilck, Martin <martin.wilck@ts.fujitsu.com>
> > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > 
> > Did I already give Tested-by's for this series (I did for those that
> > went into v4.5 pull request)?
> 
> You said you tested the crb stuff, which is this series... Did you
> test something else?

Checked my emails. Right I did run my tests for this (both with FIFO
and CRB driver). It was bit "stormy" before Christmas with all kinds
of small patches so I wasn't sure.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

> Jason

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a  per-device basis Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-01-03 18:30 +0100
  Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a  per-device basis Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-01-04 19:30 +0100
    Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a  per-device basis Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-01-04 19:40 +0100

csiph-web