Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid
Date	2016-01-04 19:30 +0100
Message-ID	<qNi3h-76n-27@gated-at.bofh.it> (permalink)
References	<qJlsJ-3li-7@gated-at.bofh.it> <qKGEN-38h-1@gated-at.bofh.it> <qL1SX-AW-23@gated-at.bofh.it> <qL50u-2OT-3@gated-at.bofh.it> <qLn73-5Wu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 30, 2015 at 3:27 AM, Michał Kępień <kernel@kempniu.pl> wrote:
>> > If you feel like I'm nit-picking and none of the above matters,
>> > please feel free to disregard my input and just follow your gut.
>>
>> It's ok. We just understand it quite differently. And in this case what
>> about changing commit message to something like this?
>>
>> ===
>> dell-wmi: Check if Dell WMI descriptor structure is valid
>>
>> After examining existing DSDT ACPI tables of more laptops and looking
>> into Dell WMI document mentioned in ML dicussion archived at
>> http://www.spinics.net/lists/platform-driver-x86/msg07220.html we will
>> parse and check WMI descriptor if contains expected data. It is because
>> WMI descriptor contains interface version number and it is needed to
>> know in next commit.
>> ===
>
> I like it way more than the previous one.
>

FWIW, the original version of this series works fine on my laptop
(after fixing the separate dmi_walk misuse bug).

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Andy Lutomirski <luto@amacapital.net> - 2016-01-04 19:30 +0100

csiph-web