Re: [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter
Date	2016-01-04 19:30 +0100
Message-ID	<qNi3g-76n-15@gated-at.bofh.it> (permalink)
References	<qGLto-32N-7@gated-at.bofh.it> <qGLto-32N-23@gated-at.bofh.it> <qMUDE-8mN-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jan 03, 2016 at 07:26:50PM +0200, Jarkko Sakkinen wrote:
> > @@ -695,8 +685,8 @@ static int tpm_tis_init(struct device *dev, struct tpm_info *tpm_info,
> >  #endif
> >  
> >  	chip->vendor.iobase = devm_ioremap_resource(dev, &tpm_info->res);
> > -	if (!chip->vendor.iobase)
> > -		return -EIO;
> > +	if (IS_ERR(chip->vendor.iobase))
> > +		return PTR_ERR(chip->vendor.iobase);
> 
> Isn't this a regression in the descendig patch in this series?

Oh yes, good catch.

The fix from Martin got rebased onto the wrong patch by accident.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-01-03 18:30 +0100
  Re: [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-01-04 19:30 +0100

csiph-web