Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search
Date	2016-01-04 19:00 +0100
Message-ID	<qNhAd-6Hd-1@gated-at.bofh.it> (permalink)
References	(3 earlier) <qK7xn-830-1@gated-at.bofh.it> <qK969-F3-1@gated-at.bofh.it> <qKgKl-5CL-11@gated-at.bofh.it> <qN9CG-1zZ-17@gated-at.bofh.it> <qNcqR-3qh-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-01-04 at 13:26 +0100, Borislav Petkov wrote:
> On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote:
> > Replied to Toshi old kernel will export the "GART" region for amd
> > cards.
> > So for old kernel and new kexec-tools we will have problem.
> > 
> > I think add the GART desc for compitibility purpose is doable, no?
> 
> Just read your other mails too. If I see it correctly, there's only one
> place which has "GART":
> 
> $ git grep -e \"GART\"
> arch/x86/kernel/crash.c:235:    walk_iomem_res("GART", IORESOURCE_MEM, 0,
> -1,
> 
> So crash.c only excludes this region but the kernel doesn't create it.
> Right?
> 
> So we can kill that walk_iomem_res(), as you say. Which would be even
> nicer...

Agreed.  As Dave suggested in the other thread, we can simply remove the
walk_iomem_res("GART",) call in crash.c.  

With this change, there will be no caller to walk_iomem_res().  Should we
remove walk_iomem_res() altogether, or keep it for now as a deprecated func
with the checkpatch check? 

Thanks,
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc()  for iomem search Dave Young <dyoung@redhat.com> - 2016-01-04 10:30 +0100
  Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc()  for iomem search Borislav Petkov <bp@alien8.de> - 2016-01-04 13:30 +0100
    Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc()  for iomem search Toshi Kani <toshi.kani@hpe.com> - 2016-01-04 19:00 +0100
      Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc()  for iomem search Toshi Kani <toshi.kani@hpe.com> - 2016-01-04 20:50 +0100
      Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc()  for iomem search Borislav Petkov <bp@alien8.de> - 2016-01-04 20:50 +0100
    Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc()  for iomem search Dave Young <dyoung@redhat.com> - 2016-01-05 06:30 +0100

csiph-web