Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access
Date	2016-01-04 16:20 +0100
Message-ID	<qNf5n-59c-9@gated-at.bofh.it> (permalink)
References	<qMhiW-qy-7@gated-at.bofh.it> <qMvce-Io-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Saturday 02 January 2016 14:17:46 Mark Brown wrote:
> On Sat, Jan 02, 2016 at 12:19:52AM +0100, Arnd Bergmann wrote:
> 
> > -             if (i2c_client->dev.of_node) {
> > +             if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) {
> 
> This would be a lot nicer if there was an __always_null annotation we
> could put on of_node for !OF configurations, that'd Just Work and this
> can't be the only case where we have this idiom.
> 

How about an inline helper like

static inline struct device_node *dev_of_node(struct device *dev)
{
	if (IS_ENABLED(CONFIG_OF))
		return dev->of_node;	
}

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] ASoC: cs35l32: avoid uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-01-02 00:30 +0100
  Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access Mark Brown <broonie@kernel.org> - 2016-01-02 15:20 +0100
    Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-01-04 16:20 +0100
      Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-04 16:30 +0100
        Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access Arnd Bergmann <arnd@arndb.de> - 2016-01-04 17:50 +0100
          Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-04 18:00 +0100
      Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access Mark Brown <broonie@kernel.org> - 2016-01-04 16:50 +0100

csiph-web