Re: [patch] mtip32xx: calling kfree() on an error pointer

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [patch] mtip32xx: calling kfree() on an error pointer
Date	2016-01-06 14:30 +0100
Message-ID	<qNWk2-1HB-21@gated-at.bofh.it> (permalink)
References	<qNTcu-87B-11@gated-at.bofh.it> <qNW0H-1yG-47@gated-at.bofh.it> <qNWam-1Ck-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 06, 2016 at 04:16:50PM +0300, Dan Carpenter wrote:
> On Wed, Jan 06, 2016 at 01:08:00PM +0000, Al Viro wrote:
> > On Wed, Jan 06, 2016 at 01:05:03PM +0300, Dan Carpenter wrote:
> > > If memdup_user() fails then we end up passing an ERR_PTR to kfree()
> > > which is a bug.
> > 
> > Mind if I fold it (with credit, obviously)?
> 
> No problem, that's fine.

Done.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] mtip32xx: calling kfree() on an error pointer Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-06 11:10 +0100
  Re: [patch] mtip32xx: calling kfree() on an error pointer Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-06 14:10 +0100
    Re: [patch] mtip32xx: calling kfree() on an error pointer Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-06 14:20 +0100
      Re: [patch] mtip32xx: calling kfree() on an error pointer Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-06 14:30 +0100

csiph-web