Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1302791
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi |
| Date | 2016-01-06 15:10 +0100 |
| Message-ID | <qNWWK-2bS-29@gated-at.bofh.it> (permalink) |
| References | <qNWal-1Ck-3@gated-at.bofh.it> <qNWam-1Ck-15@gated-at.bofh.it> <qNWk2-1HB-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi Mark,
On Wed, Jan 06, 2016 at 01:25:05PM +0000, Mark Rutland wrote:
> > + clocks {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + osc24M: osc24M_clk {
> > + #clock-cells = <0>;
> > + compatible = "fixed-clock";
> > + clock-frequency = <24000000>;
> > + clock-output-names = "osc24M";
> > + };
> > +
> > + osc32k: osc32k_clk {
> > + #clock-cells = <0>;
> > + compatible = "fixed-clock";
> > + clock-frequency = <32768>;
> > + clock-output-names = "osc32k";
> > + };
> > + };
>
> Just put the clocks under the root node. 'clocks' is not a special
> node.
No, it's not a special node, but it's a very convenient one. It avoids
"crippling" the main SoC definition with all the clocks definition,
and keep the noise relatively low.
And a bunch of other maintainers seem to agree:
$ git grep "clocks {" -- arch/arm/boot/dts/ arch/arm64/boot/dts/ | wc -l
271
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/3] Add basic support for Allwinner A83T SOC Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-01-06 14:20 +0100
[PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-01-06 14:20 +0100
Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Mark Rutland <mark.rutland@arm.com> - 2016-01-06 14:30 +0100
Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-01-06 15:10 +0100
Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-01-11 09:00 +0100
[PATCH v4 3/3] ARM: dts: sun8i: Add A83T HomletV2 Board by Allwinner Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-01-06 14:20 +0100
Re: [PATCH v4 3/3] ARM: dts: sun8i: Add A83T HomletV2 Board by Allwinner Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-01-11 09:00 +0100
csiph-web