Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1302523

Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting IRQ_DISABLE_UNLAZY flag

Show all headers | View raw

On Wed, Jan 6, 2016 at 3:40 PM, Suman Tripathi <stripathi@apm.com> wrote:
>
>
> On Wed, Jan 6, 2016 at 3:35 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>> On Wed, 6 Jan 2016, Vinod Koul wrote:
>> > On Wed, Jan 06, 2016 at 02:51:07PM +0530, Rameshwar Sahu wrote:
>> > > >> @@ -1610,6 +1611,7 @@ static int xgene_dma_request_irqs(struct
>> > > >> xgene_dma *pdma)
>> > > >>       /* Register DMA channel rx irq */
>> > > >>       for (i = 0; i < XGENE_DMA_MAX_CHANNEL; i++) {
>> > > >>               chan = &pdma->chan[i];
>> > > >> +             irq_set_status_flags(chan->rx_irq,
>> > > >> IRQ_DISABLE_UNLAZY);
>> > > >
>> > > > Why not use irq_settings_disable_unlazy(), at least read the
>> > > > reference you
>> > > > pointed out!
>> > >
>> > > irq_settings_disable_unlazy() is helper function to test
>> > > IRQ_DISABLE_UNLAZY flag is set or not, it's not for setting this flag.
>> > > FYI...
>> > > +static inline bool irq_settings_disable_unlazy(struct irq_desc *desc)
>> > > +{
>> > > + return desc->status_use_accessors & _IRQ_DISABLE_UNLAZY;
>> > > +}
>> >
>> > Ah yes, I saw clear API and assumed there would be set. Then I think we
>> > should add a set helper as well as the usage is intended for drivers to
>> > set this flag
>> >
>> > Thomas,
>> >
>> > Any reason why you didn't add a set helper, only test and clear?
>>
>> Why would I? Those helpers are core internal and not usable in random
>> drivers.
>
>
> i think the problem is the name of the function. It should be something
>
> irq_check_settings_disable_unlazy

resending in plain text mode. Sorry for this.

I think the problem is the name of the function. It should be something

irq_check_settings_disable_unlazy

>>
>>
>> Drivers have irq_set_status_flags()/irq_clear_status_flags() ...
>>
>> Thanks,
>>
>>         tglx
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>
>
> --
> Thanks,
> with regards,
> Suman Tripathi



-- 
Thanks,
with regards,
Suman Tripathi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Vinod Koul <vinod.koul@intel.com> - 2016-01-06 10:20 +0100
  Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Vinod Koul <vinod.koul@intel.com> - 2016-01-06 10:30 +0100
    Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Rameshwar Sahu <rsahu@apm.com> - 2016-01-06 10:40 +0100
    Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Thomas Gleixner <tglx@linutronix.de> - 2016-01-06 11:10 +0100
      Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Thomas Gleixner <tglx@linutronix.de> - 2016-01-06 11:20 +0100
      Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Suman Tripathi <stripathi@apm.com> - 2016-01-06 11:20 +0100
      Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Vinod Koul <vinod.koul@intel.com> - 2016-01-07 05:50 +0100
  Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting  IRQ_DISABLE_UNLAZY flag Rameshwar Sahu <rsahu@apm.com> - 2016-01-06 10:30 +0100

csiph-web