Re: [PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...)

From	José Bollo <jobol@nonadev.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...)
Date	2016-01-06 10:30 +0100
Message-ID	<qNSzN-7E8-17@gated-at.bofh.it> (permalink)
References	<qMWYO-1kX-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

I prefer the use of sizeof that can't be faked even by error but why not

Le dimanche 03 janvier 2016 à 20:56 +0100, Toralf Förster a écrit :
> use the definition in include/uapi/linux/xattr.h
> 
> Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
> ---
>  fs/ext4/xattr_security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c
> index 36f4c1a..1a3d629 100644
> --- a/fs/ext4/xattr_security.c
> +++ b/fs/ext4/xattr_security.c
> @@ -16,7 +16,7 @@ ext4_xattr_security_list(const struct xattr_handler *handler,
>  			 struct dentry *dentry, char *list, size_t list_size,
>  			 const char *name, size_t name_len)
>  {
> -	const size_t prefix_len = sizeof(XATTR_SECURITY_PREFIX)-1;
> +	const size_t prefix_len = XATTR_SECURITY_PREFIX_LEN;
>  	const size_t total_len = prefix_len + name_len + 1;
>  
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...) Toralf Förster <toralf.foerster@gmx.de> - 2016-01-03 21:00 +0100
  Re: [PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...) Jan Kara <jack@suse.cz> - 2016-01-05 18:20 +0100
  Re: [PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...) José Bollo <jobol@nonadev.net> - 2016-01-06 10:30 +0100

csiph-web