Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1302501

Re: [PATCH 1/2] prctl: take mmap sem for writing to protect against others

From Anshuman Khandual <anshuman.linux@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] prctl: take mmap sem for writing to protect against others
Date 2016-01-06 10:40 +0100
Message-ID <qNSJs-7HI-11@gated-at.bofh.it> (permalink)
References <qNOwa-546-7@gated-at.bofh.it> <qNOwa-546-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jan 6, 2016 at 10:32 AM, Mateusz Guzik <mguzik@redhat.com> wrote:
> The code was taking the semaphore for reading, which does not protect
> against readers nor concurrent modifications.

(down/up)_read does not protect against concurrent readers ?

>
> The problem could cause a sanity checks to fail in procfs's cmdline
> reader, resulting in an OOPS.
>

Can you explain this a bit and may be give some examples ?

> Note that some functions perform an unlocked read of various mm fields,
> but they seem to be fine despite possible modificaton.

Those need to be fixed as well ?

> Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] prctl: take mmap sem for writing to protect against others Mateusz Guzik <mguzik@redhat.com> - 2016-01-06 06:10 +0100
  Re: [PATCH 1/2] prctl: take mmap sem for writing to protect against others Anshuman Khandual <anshuman.linux@gmail.com> - 2016-01-06 10:40 +0100
    Re: [PATCH 1/2] prctl: take mmap sem for writing to protect against  others Mateusz Guzik <mguzik@redhat.com> - 2016-01-06 11:10 +0100

csiph-web