Re: [PATCH 2/2] module: deal with the failure of complete_formation

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] module: deal with the failure of complete_formation
Date	2016-01-06 03:00 +0100
Message-ID	<qNLyi-2LD-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <qJuFH-sh-3@gated-at.bofh.it> <qNKLT-2s3-1@gated-at.bofh.it> <qNKVA-2ww-11@gated-at.bofh.it> <qNL5g-2Bs-5@gated-at.bofh.it> <qNLoB-2IC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 06 Jan 2016 09:48:42 +0800
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com> wrote:

> On 2016/1/6 9:29, Steven Rostedt wrote:
> > On Wed, 06 Jan 2016 09:14:42 +0800
> > "Zhang, Yanmin" <yanmin_zhang@linux.intel.com> wrote:
> >
> >  
> >> It's a good idea although ftrace_module_init_fail might be complicated.  
> > How so? I posted the patch. All it does is to call
> > ftrace_release_mod(), which will only remove pages that are included
> > with the module. If the pages were not added yet, nothing is done.  
> 
> You are right. ftrace_release_mod can be used.

I was going to call that directly, but for clarity, documentation and
robustness I added the new call. Hmm, but on second thought, I noticed
that it is already shown globally. I think I'll change that back to call
ftrace_release_mod() directly.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] module: deal with the failure of complete_formation Steven Rostedt <rostedt@goodmis.org> - 2016-01-06 02:10 +0100
  Re: [PATCH 2/2] module: deal with the failure of complete_formation "Zhang, Yanmin" <yanmin_zhang@linux.intel.com> - 2016-01-06 02:20 +0100
    Re: [PATCH 2/2] module: deal with the failure of complete_formation Steven Rostedt <rostedt@goodmis.org> - 2016-01-06 02:30 +0100
      Re: [PATCH 2/2] module: deal with the failure of complete_formation "Zhang, Yanmin" <yanmin_zhang@linux.intel.com> - 2016-01-06 02:50 +0100
        Re: [PATCH 2/2] module: deal with the failure of complete_formation Steven Rostedt <rostedt@goodmis.org> - 2016-01-06 03:00 +0100

csiph-web