Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.
Date	2016-01-06 02:10 +0100
Message-ID	<qNKLU-2s3-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <jKD0e-5o1-1@gated-at.bofh.it> <kV4gi-7qa-9@gated-at.bofh.it> <kW1T4-50J-19@gated-at.bofh.it> <kWqop-1wr-1@gated-at.bofh.it> <kYwSK-2AL-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[thread necromancy, if you don't have the thread locally, it's here:
https://patchwork.kernel.org/patch/1426261/]

We still need to solve this, and John pinged me about it today. Where
does this stand?

-Kees


On Sun, Apr 14, 2013 at 7:24 AM, Anton Vorontsov <anton@enomsg.org> wrote:
> On Mon, Apr 08, 2013 at 12:54:01PM -0700, Bryan Freed wrote:
> [...]
>> And as a more general question, why should we try not to put
>> configuration in the device tree?  It seems like a great (and
>> portable) place to put this stuff.
>> It certainly seems better to have it there than hardwired in the
>> kernel or tacked onto the kernel command line.
>
> But then we have two in-kernel APIs to pass kernel parameters? So we'll
> have to maintain two ways of passing the options for each driver. That is
> hardly a good solution.
>
> If you would like to see a convenient way to pass kernel/module options
> via the device tree, I would suggest implementing something like this:
>
> chosen {
>         kernel-options {
>                 linux,pstore.record-size = 123;
>                 linux,foo = "bar";
>         };
> };
>
> And then let the kernel translate all these to module_param_*().
>
> I am still not sure about placing the options along with devices layout,
> but if we go this route, then that is also viable:
>
> pstore-node {
>         linux,pstore.record-size = 123;
> };
>
> And translate "linux,*" this to module_param_*().
>
> How does that sound?
>
> Thanks,
> Anton



-- 
Kees Cook
Chrome OS & Brillo Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened  Device Tree. Kees Cook <keescook@chromium.org> - 2016-01-06 02:10 +0100
  Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened  Device Tree. Kees Cook <keescook@chromium.org> - 2016-01-06 02:10 +0100
    Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened  Device Tree. Rob Herring <robherring2@gmail.com> - 2016-01-06 02:50 +0100

csiph-web