Re: [RFC] spi: dw: support setting tmode dynamically

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC] spi: dw: support setting tmode dynamically
Date	2016-01-05 17:20 +0100
Message-ID	<qNCv1-5eI-37@gated-at.bofh.it> (permalink)
References	<qIPMe-vw-23@gated-at.bofh.it> <qIQyC-11R-21@gated-at.bofh.it> <qIQRY-18q-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Dec 23, 2015 at 08:29:52PM +0800, Jisheng Zhang wrote:
> On Wed, 23 Dec 2015 12:15:12 +0000 Mark Brown wrote:
> > On Wed, Dec 23, 2015 at 07:23:38PM +0800, Jisheng Zhang wrote:

> > > Currently the spi-dw tmode is fixed to SPI_TMOD_TR if cs_control is NULL, but we
> > > need to set it as SPI_TMOD_EPROMREAD to read nor flash, my solution is to add and
> > > export one functions to set the tmode, then the nor flash driver call it
> > > before reading and set back to SPI_TMOD_TR after done.  

> > What does this mean - what is TMOD and why do we need to set it to read
> > NOR flash?  I've no information on this controller...

> TMOD is one field of DW_SPI_CTRL0. Its available value could be:

> 0: Transmit and Receive
> 1: Transmit only
> 2: Receive only
> 3: EEPROM Read

> If the one spi nor flash is connected to the SPI host, so far I can only succeed
> to read the nor flash content after setting the TMOD field as 3.

Why?  What does this mean in practical terms at the hardware level, what
is "EEPROM read"?  It sounds like there's some bigger issue here.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC] spi: dw: support setting tmode dynamically Mark Brown <broonie@kernel.org> - 2016-01-05 17:20 +0100
  Re: [RFC] spi: dw: support setting tmode dynamically Khoa Dang Pham <kpham@apm.com> - 2016-01-06 03:10 +0100
  Re: [RFC] spi: dw: support setting tmode dynamically Jisheng Zhang <jszhang@marvell.com> - 2016-01-06 07:30 +0100
    Re: [RFC] spi: dw: support setting tmode dynamically Khoa Dang Pham <kpham@apm.com> - 2016-01-06 08:10 +0100
      Re: [RFC] spi: dw: support setting tmode dynamically Jisheng Zhang <jszhang@marvell.com> - 2016-01-06 08:30 +0100
        Re: [RFC] spi: dw: support setting tmode dynamically Khoa Dang Pham <kpham@apm.com> - 2016-01-06 08:40 +0100
          Re: [RFC] spi: dw: support setting tmode dynamically Jisheng Zhang <jszhang@marvell.com> - 2016-01-06 08:50 +0100
  Re: [RFC] spi: dw: support setting tmode dynamically Mark Brown <broonie@kernel.org> - 2016-01-06 13:20 +0100

csiph-web